Re: [PATCH] Staging: comedi: Simplify a trivial if-return sequence

[Abdul, Hussain (H.)]

On Tuesday 16 June 2015 06:42 PM, Ian Abbott wrote:
> On 16/06/15 08:58, Abdul, Hussain (H.) wrote:
>> From: Abdul Hussain <habdul@xxxxxxxxxxx>
>>
>> This patch simplify a trivial if-return sequence. Possibly combine with
>> a preceding function call.
>>
>> Signed-off-by: Abdul Hussain <habdul@xxxxxxxxxxx>
>> ---
>>   drivers/staging/comedi/drivers/dac02.c        | 6 +-----
>>   drivers/staging/comedi/drivers/daqboard2000.c | 6 +-----
>>   drivers/staging/comedi/drivers/dmm32at.c      | 6 +-----
>>   drivers/staging/comedi/drivers/fl512.c        | 6 +-----
>>   drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
>>   drivers/staging/comedi/drivers/s626.c         | 6 +-----
>>   6 files changed, 6 insertions(+), 30 deletions(-)
>>
> Ideally, this should be split into separate patches.
>
> [snip]
>> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
>> index 611b0a3..0fe40c2 100644
>> --- a/drivers/staging/comedi/drivers/daqboard2000.c
>> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
>> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
>>   		return result;
>>
>>   	s = &dev->subdevices[2];
>> -	result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
>> +	return subdev_8255_init(dev, s, daqboard2000_8255_cb,
>>   				  dioP2ExpansionIO8Bit);
> That 'dioP2ExpansionIO8Bit' line could do with being un-indented by a 
> couple of spaces so it still lines up with the 'dev' on the preceding line.
>
Ian,

Split and sent as separate patches with the above change.

Thanks,
Abdul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/