Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

[Sagar Dharia]

On 6/15/2015 4:54 AM, Mark Brown wrote:
> On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote:
Thanks for the comments. I will take care of most of the comments from 
you, and Joe and upload V2 shortly.
I will also include a controller driver this time.
> > +void slim_ctrl_add_boarddevs(struct slim_controller *ctrl)
> > +{
> Why are these operations split?
Some slaves may choose to do expensive operations in their probes (or 
wait for logical address assignment). That will delay/block controller 
registration and further HW initialization of the controller.
I did not see any downside/side-effect in splitting them. I am open 
however to have them combined if that's the preferred way.

Thanks
Sagar

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/