Re: [PATCH] crush:Make the function crush_ln static

[Ilya Dryomov]

On Tue, Jun 9, 2015 at 11:00 AM, Ilya Dryomov <idryomov@xxxxxxxxx> wrote:
> On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause <xerofoify@xxxxxxxxx> wrote:
>> This makes the function, crush_ln static now due to having
>> only one caller in its own definition and declaration file
>> of mapper.c
>>
>> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>> ---
>>  net/ceph/crush/mapper.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
>> index 5b47736..86778d4 100644
>> --- a/net/ceph/crush/mapper.c
>> +++ b/net/ceph/crush/mapper.c
>> @@ -239,7 +239,7 @@ static int bucket_straw_choose(struct crush_bucket_straw *bucket,
>>  }
>>
>>  // compute 2^44*log2(input+1)
>> -uint64_t crush_ln(unsigned xin)
>> +static uint64_t crush_ln(unsigned xin)
>>  {
>>      unsigned x=xin, x1;
>>      int iexpon, index1, index2;
>
> This is tied up with a bunch of style cleanups, I'll apply it after
> they are sorted out.

I folded your patch into a cleanup commit [1] that also fixed
crush_ln() formatting - I hope you don't mind.

[1] https://github.com/ceph/ceph-client/commit/45c7a1f5df419e53c17f2eeb5680d6fb20a07162

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/