Re: [PATCH v5 04/14] crypto: add a new driver for Marvell's CESA

[Boris Brezillon]

On Wed, 17 Jun 2015 13:58:24 +0800
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Jun 16, 2015 at 11:58:58AM +0200, Boris Brezillon wrote:
> >
> > +config CRYPTO_DEV_MARVELL_CESA
> > +	tristate "New Marvell's Cryptographic Engine driver"
> > +	depends on (PLAT_ORION || ARCH_MVEBU || COMPILE_TEST) && HAS_DMA && HAS_IOMEM
> > +	select CRYPTO_ALGAPI
> > +	select CRYPTO_AES
> > +	select CRYPTO_DES
> > +	select CRYPTO_BLKCIPHER2
> > +	select CRYPTO_HASH
> 
> While you're fixing the DMA issue, could you also replace BLKCIPHER2
> with BLKCIPHER and kill the select on ALGAPI? BLKCIPHER2 is internal
> to the crypto API and should not be used elsewhere while ALGAPI is
> only meant to be selected by crypto types such as BLKCIPHER.
> 
> I know the existing driver does this too and I will fix that now.

Fixed.

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/