Re: [PATCH V2 2/6] of/slimbus: OF helper for SLIMbus

From: Mark Brown
Date: Wed Jun 17 2015 - 09:11:07 EST

On Tue, Jun 16, 2015 at 07:46:00PM -0600, Sagar Dharia wrote:
> OF helper routine scans the SLIMbus DeviceTree, allocates resources,
> and creates slim_devices according to the hierarchy.

You've not CCed any of the DT maintainers on this, for a completely new
bus it seems like we really ought to get their input.

> @@ -0,0 +1,34 @@
> +SLIM(Serial Low Power Interchip Media Bus) bus
> +
> +SLIMbus is a 2-wire bus, and is used to communicate with peripheral
> +components like audio-codec.
> +
> +Required property for SLIMbus controller node:
> +- compatible - name of SLIMbus controller.
> +
> +No other properties are required in the SLIMbus controller bus node.

It seems better to just say that the controller is a normal device using
the binding for whatever bus it is on and that the binding is for the
bus which is a child node of the controller device? Also, do we need
#address-cells or #size-cells here?

> +Required property for SLIMbus child node:
> +enumeration-addr - 6 byte enumeration address of the slave

The idiom for DT seems to be that we define the bus address using the
reg property. Should we not be following that pattern here too? I'd
also expect to see the ability to define a compatible for the slaves.

Attachment: signature.asc
Description: Digital signature