RE: [PATCH 01/12] fsl/fman: Add the FMan FLIB headers

[Liberman Igal]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, June 10, 2015 9:54 PM
> To: Bucur Madalin-Cristian-B32716
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linuxppc-
> dev@xxxxxxxxxxxxxxxx; Liberman Igal-B31950
> Subject: Re: [PATCH 01/12] fsl/fman: Add the FMan FLIB headers
> 
> On Wed, 2015-06-10 at 18:21 +0300, Madalin Bucur wrote:
> > From: Igal Liberman <Igal.Liberman@xxxxxxxxxxxxx>
> >
> > This patch presents the FMan Foundation Libraries (FLIB) headers.
> > The FMan FLib provides the basic API used by the FMan drivers to
> > configure and control the FMan hardware.
> >
> > Signed-off-by: Igal Liberman <Igal.Liberman@xxxxxxxxxxxxx>
> > ---
> >  .../ethernet/freescale/fman/flib/common/general.h  |  41 ++
> >  .../net/ethernet/freescale/fman/flib/fsl_fman.h    | 609
> > +++++++++++++++++++++
> >  2 files changed, 650 insertions(+)
> >  create mode 100644
> > drivers/net/ethernet/freescale/fman/flib/common/general.h
> >  create mode 100644
> > drivers/net/ethernet/freescale/fman/flib/fsl_fman.h
> 
> Why do we need separate patches just for headers?
> 

We wanted to make the patches smaller, it's the main reason for this separation.

> What does "common" refer to?
> 

I removed ./flib/common.

> What does the flib directory mean, in the context of Linux?  If someone were
> to add code to this driver, how do they know if the code should go into the
> flib directory or not?
> 
> >
> > +#define iowrite32be(val, addr)               out_be32(&(*addr), val)
> > +#define ioread32be(addr)             in_be32(&(*addr))
> 
> iowrite32be()/ioread32be() are already defined for all relevant architectures.
> Why are you redefining them into something PPC- specific?
> 

Removed those. 

> > +/* do not change! if changed, must be disabled for rev1 ! */ #define
> > +DEFAULT_HALT_ON_EXTERNAL_ACTIVATION  false
> > +/* do not change! if changed, must be disabled for rev1 ! */ #define
> > +DEFAULT_HALT_ON_UNRECOVERABLE_ECC_ERROR false
> 
> rev1 of what chip?
> 

P4080. I'll update the comments. 

> -Scott

Igal.