Re: [PATCH 1/3] ARM: at91/soc: add basic support for new sama5d2 SoC
From: Alexandre Belloni
Date: Thu Jun 18 2015 - 11:21:15 EST
Hi,
On 18/06/2015 at 15:18:28 +0200, Nicolas Ferre wrote :
> diff --git a/Documentation/arm/Atmel/README b/Documentation/arm/Atmel/README
> index c53a19b4aab2..6650a8ffaa64 100644
> --- a/Documentation/arm/Atmel/README
> +++ b/Documentation/arm/Atmel/README
> @@ -90,6 +90,12 @@ the Atmel website: http://www.atmel.com.
> + Datasheet
> http://www.atmel.com/Images/Atmel-11238-32-bit-Cortex-A5-Microcontroller-SAMA5D4_Datasheet.pdf
>
> + * ARM Cortex-A5 + NEON based SoCs
> + - sama5d2 family
> + - sama5d27
> + + Datasheet
> + Coming soon
Shouldn't that go directly before or after the sama5d4 family ?
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index f1b157971366..140228d033c2 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -141,6 +141,12 @@ choice
> depends on ARCH_AT91
> depends on SOC_SAMA5
>
> + config AT91_DEBUG_LL_DBGU3
> + bool "Kernel low-level debugging on sama5d2"
> + select DEBUG_AT91_UART
> + depends on ARCH_AT91
> + depends on SOC_SAMA5
> +
I think that at some point we'll have to kill those AT91_DEBUG_LL_*
which are actually board specific and not soc specific. I already have a
patch for that that I need to rebase.
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 43ec794d1057..e53780a28605 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -8,6 +8,18 @@ menuconfig ARCH_AT91
> select SOC_BUS
>
> if ARCH_AT91
> +config SOC_SAMA5D2
> + bool "SAMA5D2 family" if ARCH_MULTI_V7
> + select SOC_SAMA5
> + select CACHE_L2X0
> + select HAVE_FB_ATMEL
> + select HAVE_AT91_UTMI
> + select HAVE_AT91_USB_CLK
> + select HAVE_AT91_H32MX
> + select HAVE_AT91_GENERATED
Seeing that, I think HAVE_AT91_GENERATED should include CLK somewhere in
the name as this is only related to clocks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/