Re: [PATCH] irqchip: bcm2835: Add FIQ support

From: Noralf TrÃnnes
Date: Thu Jun 18 2015 - 12:23:56 EST



Den 18.06.2015 15:32, skrev Noralf TrÃnnes:

Den 18.06.2015 04:26, skrev Stephen Warren:
On 06/12/2015 11:26 AM, Noralf TrÃnnes wrote:
Add a duplicate irq range with an offset on the hwirq's so the
driver can detect that enable_fiq() is used.
Tested with downstream dwc_otg USB controller driver.
This basically looks OK, but a few comments/thoughts:


c) The DT binding needs updating to describe the extra IRQs:

Documentation/devicetree/bindings/interrupt-controller/brcm,bcm28armctrl-ic.txt

Ok.


I have seconds thoughts on this:
This patch does not change the DT bindings so I don't see what update
I should make. This patch only adds support for the Linux way of
handling FIQ's through enable_fiq(). It doesn't change how interrupts
are described in the DT.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/