Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

[Steven Rostedt]

On Thu, 18 Jun 2015 10:59:31 -0700
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote:
> > Changes to existing files to add 0pf j2 board support.
> > 
> 
> That's the second worse commit message and subject: line I've read
> today.

Only the second worse today? Damn, you must get a lot of crappy change
logs.

> 
> And there's no signed off by line.
> 
> And there was no 1/2 patch sent.
> 
> And, most importantly:
> 
> > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> 
> I don't care about arch/sh/ stuff, why are you sending this to me?

Because even when you don't care, you still give back constructive
feedback ;-)

-- Steve


> 
> You have a bit of work to do here...
> 
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/