Re: [PATCH 3/3] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore

[Andi Kleen]

> So now we return success, if nothing is there or stuff failed?

Right.

> 
> One possible solution is to split the initcall and have one
> for uncore_pci and one for uncode_msr, but that does not work well if
> you want to make it a module.
> 
> But we should at least have some indication, what worked and what went
> wrong instead of unconditionally returning success.

Nobody uses the return value for builtin drivers (short of one
debug printk). It would not load the module, but right now we don't
have a module.

Generally it's a bad idea to print something when a probe doesn't work,
as that just leads to lots of dmesg spam for large monolithic kernels.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/