[PATCH] fs: inotify: systemd needs it so make it depend on CONFIG_EMBEDDED

From: Dave Hansen
Date: Fri Jun 19 2015 - 14:08:28 EST



From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>

I have a little microbenchmark that sits and does write() in a loop.
The number one kernel function in the profiles is __srcu_read_lock()
from fsnotify(). I decided to turn off INOTIFY in order to see what
the potential from optimizing this path would be. I ended up with
a system at the rescue console as systemd complained that dependencies
were not met mounting some non-root filesystems:

systemd: inotify_init1() failed: Function not implemented
systemd: Dependency failed for Mark the need to relabel after reboot.
systemd: Triggering OnFailure= dependencies of local-fs.target.
systemd: inotify_init1() failed: Function not implemented
systemd: Dependency failed for /gcc.

It looks like CONFIG_INOTIFY is now a critical part of any system
that wants to both use systemd and boot. Let's make it depend
on CONFIG_EMBEDDED.

Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Cc: John McCutchan <john@xxxxxxxxxxxxxxxxx>
Cc: Robert Love <rlove@xxxxxxxxx>
Cc: Eric Paris <eparis@xxxxxxxxxxxxxx>
Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx

---

b/fs/notify/inotify/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/notify/inotify/Kconfig~make-inotify-harder-to-turn-off fs/notify/inotify/Kconfig
--- a/fs/notify/inotify/Kconfig~make-inotify-harder-to-turn-off 2015-06-19 10:54:06.528721072 -0700
+++ b/fs/notify/inotify/Kconfig 2015-06-19 10:55:16.426892530 -0700
@@ -1,5 +1,5 @@
config INOTIFY_USER
- bool "Inotify support for userspace"
+ bool "Inotify support for userspace" if EMBEDDED
select ANON_INODES
select FSNOTIFY
default y
_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/