Re: [PATCH] MIPS: KVM: do not sign extend on unsigned MMIO load

From: Greg KH
Date: Fri Jun 19 2015 - 15:14:23 EST


On Mon, Jun 08, 2015 at 09:33:50AM +0100, James Hogan wrote:
> Hi stable folk,
>
> On 08/05/15 15:16, James Hogan wrote:
> > On 07/05/15 13:47, Nicholas Mc Guire wrote:
> >> Fix possible unintended sign extension in unsigned MMIO loads by casting
> >> to uint16_t in the case of mmio_needed != 2.
> >>
> >> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> >
> > Looks good to me. I wrote an MMIO test to reproduce the issue, and this
> > fixes it.
> >
> > Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>
> > Tested-by: James Hogan <james.hogan@xxxxxxxxxx>
> >
> > It looks suitable for stable too (3.10+).
>
> This has reached mainline, commit ed9244e6c534612d2b5ae47feab2f55a0d4b4ced
>
> Please could it be added to stable (3.10+).

It does not apply to 3.10 or 3.14-stable, so please provide a backport
if you want it there.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/