Re: [PATCH] staging: comedi: fix sparse warning in comedi_compat32.c

[Geliang Tang]

On Sat, Jun 20, 2015 at 04:08:19PM +0530, Sudip Mukherjee wrote:
> compat_ptr is already a typecast.
> static inline void __user *compat_ptr(compat_uptr_t uptr)
> {
>       return (void __user *)(unsigned long)uptr;
> }
> 
> so you are adding another typecast to an already exitsing typecast. :(
> 
> and besides, this also introduces one new checkpatch warning of
> line more than 80 char.
> 
> regards
> sudip

Thank you for your review. I revised the patch as you suggested. Here it is.

Geliang Tang (1):
  staging: comedi: fix cast warning in comedi_compat32.c

 drivers/staging/comedi/comedi_compat32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.3.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/