Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions

From: Robert Jarzmik
Date: Sat Jun 20 2015 - 17:50:34 EST


Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes:

>> +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev,
>> + enum pxa_camera_active_dma act_dma);
>> +
>> +static void pxa_camera_dma_irq_y(void *data)
>
> Wait, how is this patch trivial? You change pxa_camera_dma_irq_?()
> prototypes, which are used as PXA DMA callbacks. Does this mean, that
> either before or after this patch compilation is broken?

Jeez you're right.
So I can either fold that with patch 4, or try to rework it somehow ...

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/