Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM

[Javier Martinez Canillas]

Hello Paul,

On 06/21/2015 02:01 AM, Paul Gortmaker wrote:
> In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
> Move protocol helpers out of the MFD driver") there was a select
> added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
> 
> warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
> direct dependencies (X86 || ARM)
>

Right, sorry for missing that and thank a lot for taking care of it.
 
> Presumably the above means MFD_CROS_EC is only currently useful
> on x86 and ARM, so lets limit it to there.
>

That is correct, although I wonder if CHROME_PLATFORMS should not
also depend on || COMPILE_TEST and same for MFD_CROS_EC so those
have at least build coverage on other architectures.

I can't think for a reason to not be buildable on other archs...

> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: Olof Johansson <olof@xxxxxxxxx>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..d3235e6f1953 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -94,6 +94,7 @@ config MFD_AXP20X
>  
>  config MFD_CROS_EC
>  	tristate "ChromeOS Embedded Controller"
> +	depends on X86 || ARM
>  	select MFD_CORE
>  	select CHROME_PLATFORMS
>  	select CROS_EC_PROTO
> 

...but that is orthogonal to this patch so:

Acked-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/