Re: [PATCH 10/15] libnvdimm: fix up max_hw_sectors

From: Dan Williams
Date: Sun Jun 21 2015 - 09:28:57 EST


On Sun, Jun 21, 2015 at 3:08 AM, Christoph Hellwig <hch@xxxxxx> wrote:
>> +void nd_blk_queue_init(struct request_queue *q)
>> +{
>> + blk_queue_max_hw_sectors(q, UINT_MAX);
>> + blk_queue_bounce_limit(q, BLK_BOUNCE_ANY);
>> +}
>
> Please just add the calls to the drivers instead of this helper which
> hides the intent.

I thought it made it clearer what properties are shared between block
devices on an nvdimm bus, but if you're initial reaction is that it
hides intent I'll kill the helper.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/