Re: [PATCH v5] NET: Add ezchip ethernet driver

[David Miller]

From: Noam Camus <noamc@xxxxxxxxxx>
Date: Tue, 16 Jun 2015 17:35:42 +0300

> From: Noam Camus <noamc@xxxxxxxxxx>
> 
> Simple LAN device for debug or management purposes.
> Device supports interrupts for RX and TX(completion).
> Device does not have DMA ability.
> 
> Signed-off-by: Noam Camus <noamc@xxxxxxxxxx>
> Signed-off-by: Tal Zilcer <talz@xxxxxxxxxx>
> Acked-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>

This builds with several warnings and also doesn't compile.

drivers/net/ethernet/ezchip/nps_enet.c: In function ʽnps_enet_read_rx_fifoʼ:
drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c: In function ʽnps_enet_send_frameʼ:
drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c: In function ʽnps_enet_poll_controllerʼ:
drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ʽnps_enet_board_irq_handlerʼ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

I do not even see where npe_enet_board_irq_handler could possible be defined.

It is quite infuriating to receive a patch like this which is claimed
to be complete and ready to be applied to my tree, yet it is very
clearly not.