Re: [GIT PULL] tracing: Have filter check for balanced ops

From: Luis Henriques
Date: Mon Jun 22 2015 - 10:49:55 EST

On Mon, Jun 22, 2015 at 10:17:28AM -0400, Steven Rostedt wrote:
> To make this patch simpler, just move the "cnt--;" above the OP_AND and
> OP_OR check and remove the "cnt--;" from that if statement.
> But yeah, this looks fine. You can test it with the example in the
> change log.
> echo "((dev==1)blocks==2)" > events/ext4/ext4_truncate_exit/filter
> And see if it gives an error other than "parse_error: No error".
> -- Steve

Thanks Steven, I've done a quick test with a 3.16-ckt kernel and I can
confirm that the modified patch (i.e. including your suggestion) fixes
the problem.

I'm attaching the patch below and CC'ing stable mailing-list.