Re: [PATCH v4 12/12] MIPS: Add basic support for the TL-WR1043ND version 1

[Antony Pavlov]

On Sat, 20 Jun 2015 12:51:37 +0200
Alban <albeu@xxxxxxx> wrote:

> On Mon, 15 Jun 2015 10:42:13 +0300
> Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote:
> 
> > On Wed, 10 Jun 2015 23:58:11 +0200
> > Alban <albeu@xxxxxxx> wrote:
> > 
> > > On Mon, 8 Jun 2015 13:17:58 +0300
> > > Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote:
> > > 
> > > > IMHO AR9132 SoC can't work without external oscilator.
> > > > 
> > > > Can we just move basic extosc declaration to SoC dt file
> > > > (ar9132.dtsi)? So board dt file ar9132_tl_wr1043nd_v1.dts will
> > > > contain only oscilator clock frequency value.
> > > 
> > > I would prefer to keep the split between the files in sync with the
> > > hardware. I understand that most simple board designs use a fixed
> > > oscillator, but that might not always be the case.
> > > 
> > 
> > The AR9132 SoC __always__ use one external oscilator.
> 
> Yes, but what I don't like is to impose the clock source being a
> fixed-oscillator. What if the board use a clock from another
> component that need to be represented in the DT as something else
> than a fixed-oscillator?

The absolute majority of the ar9132-based boards has fixed-oscillator
(Actually I suppose all of them has fixed oscillator).

If some board has different clock source then we can completely alter
extosc node in the board dts file. (But I have some doubts in existence
of such board.)

-- 
Best regards,
  Antony Pavlov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/