Re: [v2,2/3] watchdog: max63xx: add GPIO support

[Vivien Didelot]

Hi Guenter,

On Jun 22, 2015, at 12:53 PM, Guenter Roeck linux@xxxxxxxxxxxx wrote:
> On Wed, Jun 17, 2015 at 06:58:59PM -0400, Vivien Didelot wrote:
>> Introduce a new struct max63xx_platform_data to support MAX63xx watchdog
>> chips connected via GPIO. A platform code can fill this structure with
>> GPIO numbers for WDI and WDSET pins to enable GPIO support in the code.
>> 
>> The driver takes care of requesting and releasing the GPIOs.
>> 
>> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
> 
> would it be possible to use gpiod functions ?

It might be, but I never played with it yet though. I'm using integer-based
GPIOs from a TCA6424 on an x86 platform (no Device Tree). Is it ok to keep
max63xx_gpio_{ping,set} for legacy GPIOs, and let someone add
max63xx_gpiod_{ping,set} if there is a need?

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/