Re: [Intel-gfx] [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

[Lee Jones]

On Mon, 22 Jun 2015, Daniel Vetter wrote:

> On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote:
> > Hi Shobhit Kumar,
> > 
> > On 06/22/2015 04:24 PM, Shobhit Kumar wrote:
> > 
> > >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup
> > >entry for the same to be used by the consumer (Intel GFX)
> > >
> > >v2: Remove the lookup table on driver unload (Thierry)
> > >
> > >v3: Correct the subject line (Lee jones)
> > 
> > This part should only describe what this is about..
> > 
> > Don't put this patch change history over here.
> > Include this change history after
> > ...
> > Signed-off-by: Author <email>
> > ---
> > 
> > >CC: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> > >Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > >Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> > >Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> > >Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > >Signed-off-by: Shobhit Kumar <shobhit.kumar@xxxxxxxxx>
> > >---
> > 
> > Here you add this change history so that after applying this
> > will not be the part of your commit description.
> > 
> > This comment is applicable for all of your patches.
> 
> It's honestly a per-maintainer thing and hard to tell who wants what ...
> Personally I do want to include the patch changelog in the commit message.

The patch change-log should go below the '---'.  There are very few
(weird ;) ) Maintainers who like to see them in the commit log.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/