Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

From: Viresh Kumar
Date: Tue Jun 23 2015 - 04:31:22 EST

On 23-06-15, 09:27, Lee Jones wrote:
> Okay, but the reasoning is the same. I consider the function to have
> failed, but the over-all failure culminates in just a warning that
> voltage scaling has indeed failed, but we can still go on with
> frequency scaling.

Ahh, I thought that the other opp-table will also have voltages.

> Unless his is a big blocker for you, I would like to keep these
> semantics.

No, the print is actually fine.

> So technically you are correct, but it makes the code slightly more
> confusing IMHO. Yes, it's one more line of code, but it's worth it to
> add clarity.

Your call :)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at