Re: [PATCH] net: dsa: mv88e6xxx: split phy page accessors

From: David Miller
Date: Tue Jun 23 2015 - 09:06:48 EST


From: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 19 Jun 2015 10:32:10 -0400

> Split mv88e6xxx_phy_page_read and mv88e6xxx_phy_page_write into two
> functions each, one to acquire the smi_mutex and one to call the actual
> read/write functions.
>
> This will be useful to access registers such as Fiber/SERDES Control,
> from setup code with SMI lock held.
>
> Also rename their "error" labels to "clear", since it is not only an
> error path.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>

Please resubmit this alongside a patch that actually uses the new
facility.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/