Re: [PATCH 2/3] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB
From: Rob Herring
Date: Tue Jun 23 2015 - 10:17:55 EST
On Mon, Jun 22, 2015 at 6:52 PM, Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> Some SoCs with a dwc2 USB controller may need to keep the PHY on to
> support remote wakeup. Allow specifying this as a device tree
I find it hard to believe that any host can support wake-up without
the PHY. Does this really need to be conditional? Perhaps other cases
are just always-on or remote wake-up has not been tested.
Assuming the PHY was provided with the knowledge that remote wakeup is
enabled, it would be able to figure out within its driver how to
support that. Unfortunately the generic PHY framework is a completely
lacking in its ability to support protocol specific features like this
or other USB PHY features like Vbus detect or charger detection.
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Documentation/devicetree/bindings/usb/dwc2.txt | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
> index fd132cb..84d258d 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc2.txt
> @@ -17,6 +17,9 @@ Refer to clk/clock-bindings.txt for generic clock consumer properties
> Optional properties:
> - phys: phy provider specifier
> - phy-names: shall be "usb2-phy"
> +- snps,need-phy-for-wake: if present indicates that the phy needs to be left
> + on for remote wakeup during suspend.
> Refer to phy/phy-bindings.txt for generic phy consumer properties
> - dr_mode: shall be one of "host", "peripheral" and "otg"
> Refer to usb/generic.txt
> @@ -35,4 +38,5 @@ Example:
> clock-names = "otg";
> phys = <&usbphy>;
> phy-names = "usb2-phy";
> + snps,need-phy-for-wake;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/