Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

From: Luis de Bethencourt
Date: Tue Jun 23 2015 - 19:16:08 EST


On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
> Nope. Your patch is totally wrong (buggy). Please be more careful in
> the future.
>
> regards,
> dan carpenter
>

I saw other commits replace the obsolete simple_strtoul() this way and the
documentation makes it look like it is a 1 to 1 replacement.

Sorry about this. I will investigate further to understand why this is buggy
and be more careful in the future.

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/