Re: problem with checkpatch

From: Sudip Mukherjee
Date: Wed Jun 24 2015 - 00:42:50 EST


On Tue, Jun 23, 2015 at 10:31:46AM -0700, Joe Perches wrote:
> On Tue, 2015-06-23 at 18:06 +0530, Sudip Mukherjee wrote:
> > Hi Joe,
> > while checking patches I usually check them using mutt pipe to checkpatch.
> > while in mutt, press '|' and then scripts/checkpatch.pl -
> > and the patch will be checked by checkpatch without having to save it.
> >
> > Now 700152391c3d ("checkpatch: add --showfile to allow input via pipe to show filenames")
> > is adding $filename ne '-' and because of that if the patch has any
> > error in Signed-off-by , it is not detecting anymore.
>
> Any error in signature format should still be found,
> but a missing sign-off line would not.
yes, the patch with which i noticed this was not having the Signed-off

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/