Re: [PATCH 0/8] Qualcomm PMIC pinctrl additions
From: Ivan T. Ivanov
Date: Wed Jun 24 2015 - 04:29:51 EST
On Wed, 2015-06-17 at 23:47 -0700, Bjorn Andersson wrote:
> This series starts out by fixing various issues found in the pm8941 mpp driver.
> While doing this work, and trying to use the mpp driver from device tree it, it
> became obvious that the current binding is not fit for neither the driver
> implementation nor the dts implementation.
>
> The main reason for this is that we "inherited" the functions from the gpio
> driver, where there is a notion of functions. But in the MPP the logical
> mapping of digital, analog and current sink makes much more sense to map as
> "functions". The features previously exposed as functions are replaced by two
> properties (qcom,paired and qcom,dtest).
>
> The end result is a more natural device tree definition.
>
> With this in place the series introduces the gpio and mpp drivers for the ssbi
> based pmics; found in 8660, 8960 and 8064.
>
> Bjorn Andersson (8):
> pinctrl: qcom: spmi-mpp: Transition to generic dt binding parser
> pinctrl: qcom: spmi-mpp: Fixes related to enable handling
> pinctrl: qcom: spmi-mpp: Introduce defines for MODE_CTL
> pinctrl: qcom: spmi-mpp: Implement support for sink mode
> pinctrl: qcom: spmi-mpp: Add support for setting analog output level
> pinctrl: qcom: spmi-mpp: Transpose pinmux function
> mfd: pm8921: Implement irq_get_irqchip_state
> pinctrl: qcom: ssbi: Family A gpio & mpp drivers
Thank you Bjorn.
Now MPP drivers have its full functionality.
With two small comments on patch 5 and 8,
Reviewed-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/