Re: [PATCH v6 3/9] nvmem: Add nvmem_device based consumer apis.

From: Srinivas Kandagatla
Date: Wed Jun 24 2015 - 05:52:55 EST




On 23/06/15 21:28, Stefan Wahren wrote:
>@@ -26,6 +35,21 @@ void devm_nvmem_cell_put(struct device *dev, struct
>nvmem_cell *cell);
>void *nvmem_cell_read(struct nvmem_cell *cell, ssize_t *len);
>int nvmem_cell_write(struct nvmem_cell *cell, void *buf, ssize_t len);
>
>+/* direct nvmem device read/write interface */
>+struct nvmem_device *nvmem_device_get(struct device *dev, const char *name);
>+struct nvmem_device *devm_nvmem_device_get(struct device *dev,
>+ const char *name);
>+void nvmem_device_put(struct nvmem_device *nvmem);
>+void devm_nvmem_device_put(struct device *dev, struct nvmem_device *nvmem);
>+int nvmem_device_read(struct nvmem_device *nvmem, unsigned int offset,
>+ size_t bytes, void *buf);
>+int nvmem_device_write(struct nvmem_device *nvmem, unsigned int offset,
>+ size_t bytes, void *buf);
Maybe i mixed something but those functions use the datatype unsigned int for
offset
and the offset in the structs use datatype int. Looks a little bit inconsistent.
thanks for comments,

I will have a relook at this and see if I can fix it.

thanks,
srini
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/