Re: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

[Vitaly Kuznetsov]

Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:

> On Wed, Jun 24, 2015 at 11:43:33AM +0200, Vitaly Kuznetsov wrote:
>> Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:
>> > On Tue, Jun 23, 2015 at 04:57:05PM +0000, KY Srinivasan wrote:
>> >
>> >> > diff --git a/kernel/cpu.c b/kernel/cpu.c
>> >> > index 94bbe46..8f35ee6 100644
>> >> > --- a/kernel/cpu.c
>> >> > +++ b/kernel/cpu.c
>> >> > @@ -190,17 +190,19 @@ void cpu_hotplug_done(void)
>> >> >  void cpu_hotplug_disable(void)
>> >> >  {
>> >> >  	cpu_maps_update_begin();
>> >> > -	cpu_hotplug_disabled = 1;
>> >> > +	cpu_hotplug_disabled++;
>> >> >  	cpu_maps_update_done();
>> >> >  }
>> >> > +EXPORT_SYMBOL_GPL(cpu_hotplug_disable);
>> >> > 
>> >> >  void cpu_hotplug_enable(void)
>> >> >  {
>> >> >  	cpu_maps_update_begin();
>> >> > -	cpu_hotplug_disabled = 0;
>> >> > +	if (cpu_hotplug_disabled)
>> >> > +		cpu_hotplug_disabled--;
>> >
>> > No that just papers over bugs.
>> 
>> Yes, but these bugs are not in Linux. I don't see any other way for a
>> platform to enable/disable cpu hotplug in runtime.
>
> Any code using this had better be open source, if not I really don't
> care anyway.
>
> That really ought to be:
>
> 	WARN_ON(--cpu_hotplug_disabled < 0);
>
> You do not make underflows go away.

Sorry, I was under an impression you were referring to the patch as a
whole :-) Yes, I agree, let's add this WARN_ON().

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/