Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM
From: Heiko Stübner
Date: Wed Jun 24 2015 - 10:21:44 EST
Am Mittwoch, 24. Juni 2015, 15:17:50 schrieb Lee Jones:
> On Sun, 21 Jun 2015, Javier Martinez Canillas wrote:
> > Hello Paul,
> >
> > On 06/21/2015 02:01 AM, Paul Gortmaker wrote:
> > > In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
> > > Move protocol helpers out of the MFD driver") there was a select
> > > added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
> > >
> > > warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
> > > direct dependencies (X86 || ARM)
> >
> > Right, sorry for missing that and thank a lot for taking care of it.
> >
> > > Presumably the above means MFD_CROS_EC is only currently useful
> > > on x86 and ARM, so lets limit it to there.
> >
> > That is correct, although I wonder if CHROME_PLATFORMS should not
> > also depend on || COMPILE_TEST and same for MFD_CROS_EC so those
> > have at least build coverage on other architectures.
> >
> > I can't think for a reason to not be buildable on other archs...
>
> Right. Will you fix that Javier?
looking at the ChromeOS kernel tree (3.18 / oak) it looks like ARM64 might
also be a nice addition to this list, but I'm not sure if there are more ec
changes involved.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/