Re: [PATCH 1/1] mm: move ->mremap() from file_operations to vm_operations_struct

[Oleg Nesterov]

On 06/23, Oleg Nesterov wrote:
>
> On 06/23, Kirill A. Shutemov wrote:
> >
> > On Tue, Jun 23, 2015 at 08:02:51PM +0200, Oleg Nesterov wrote:
> > > vma->vm_ops->mremap() looks more natural and clean in move_vma(),
> > > and this way ->mremap() can have more users. Say, vdso.
> > >
> > > Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> > > ---
> > >  fs/aio.c           |   25 ++++++++++++++++---------
> > >  include/linux/fs.h |    1 -
> > >  include/linux/mm.h |    1 +
> > >  mm/mremap.c        |    4 ++--
> >
> > Please, update Documentation/filesystems/Locking.
>
> OK, thanks, will do.

Wait... Documentation/filesystems/Locking doesn't mention
->mremap() at all.

So you actually ask me to add the new documentation? ;)

Oh well... OK, I'll try if you think this is necessary.

I tried to make the minimal change before ->mremap() finds another
user in file_operations. I thinks it needs more arguments, at least
new_addr and new_len, otherwise it is not easy to document it. The
same for f_op->mremap() of course.

Currently this does not matter, the only user is aio.c and
VM_DONTEXPAND means that it is not mergeable, so mremap() always
creates the new vma.

Hmm. Can't we do this change and add the documentation later?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/