Re: [PATCH 1/3] drm/doc: Add description of drm properties in msm

[Rob Clark]

On Fri, Jun 19, 2015 at 11:36 AM, Jilai Wang <jilaiw@xxxxxxxxxxxxxx> wrote:
> Add plane properties "premultiplied/zpos/alpha" used in msm MDP
> driver to perform proper blending operation.
>
> Signed-off-by: Jilai Wang <jilaiw@xxxxxxxxxxxxxx>
> ---
>  Documentation/DocBook/drm.tmpl | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index 109fde8..9dc0940 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -3500,6 +3500,29 @@ void intel_crt_init(struct drm_device *dev)
>         <td valign="top" >Plane</td>
>         <td valign="top" >TBD</td>
>         </tr>
> +       <tr>
> +       <td rowspan="3" valign="top" >msm</td>
> +       <td rowspan="3" valign="top" >Generic</td>
> +       <td valign="top" >"premultiplied"</td>
> +       <td valign="top" >RANGE</td>

probably an ENUM property for this?

> +       <td valign="top" >Min=0, Max=1</td>
> +       <td valign="top" >Plane</td>
> +       <td valign="top" >property to indicate the framebuffer used by this plane is alpha pre-multiplied</td>
> +       </tr>
> +       <tr>
> +       <td valign="top" >"alpha"</td>
> +       <td valign="top" >RANGE</td>
> +       <td valign="top" >Min=0, Max=255</td>
> +       <td valign="top" >Plane</td>
> +       <td valign="top" >property to set plane's global alpha value</td>
> +       </tr>
> +       <tr>
> +       <td valign="top" >"zpos"</td>
> +       <td valign="top" >RANGE</td>
> +       <td valign="top" >Min=1, Max=255</td>
> +       <td valign="top" >Plane</td>
> +       <td valign="top" >property to set plane's z position during blending</td>

looks like we already have alpha and zpos props..  although it
wouldn't hurt to copy your description over for those props, since it
is a bit more complete than "TBD" that we have currently

BR,
-R

> +       </tr>
>         </tbody>
>         </table>
>      </sect2>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/