Re: [PATCH v3 09/15] x86/entry/64: Migrate 64-bit and compat syscalls to new exit hooks

From: Andy Lutomirski
Date: Wed Jun 24 2015 - 17:18:50 EST


On Tue, Jun 23, 2015 at 7:46 PM, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
>
> @@ -227,11 +227,10 @@ sysexit_from_sys_call:
> testl %edi, ASM_THREAD_INFO(TI_flags, %rsp, SIZEOF_PTREGS)
> jz \exit
> xorl %eax, %eax /* Do not leak kernel information */
> - movq %rax, R11(%rsp)
> + jmp int_ret_from_sys_call_irqs_off
> movq %rax, R10(%rsp)
> movq %rax, R9(%rsp)
> movq %rax, R8(%rsp)
> - jmp int_with_check
> .endm
>

Crud. I hate code like this with no usable test (although the thing
Denys is working on should catch this). There's an obvious rebase
error here. :(

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/