Re: linux-next: build failure after merge of the modules tree

From: Stephen Rothwell
Date: Wed Jun 24 2015 - 21:50:38 EST


Hi Dan,

On Thu, 25 Jun 2015 08:57:06 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 24 Jun 2015 14:18:44 -0400 Dan Streetman <ddstreet@xxxxxxxx> wrote:
> >
> > On Tue, Jun 23, 2015 at 9:37 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > After merging the modules tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> >
> > that's weird. Are you sure it failed during allmodconfig? I can see
> > why it would fail like that if CONFIG_MODULES ins't defined, which
> > I'll send a patch for...
>
> Pretty sure - and, in any case, I don't do any CONFIG_MODULES=n builds
> between tree merges (only later in the day). That is why I couldn't
> figure out what went wrong.
>
> I will apply your patch today and see if that helps.

I built without your patch and it failed again, but applying your patch fixes it.

Rusty, you can consider this

Tested-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

for "[PATCH] modules: only use mod->param_lock if CONFIG_MODULES"
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgpql8UgQKIkR.pgp
Description: OpenPGP digital signature