Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver

[Peter Hung]

Hi Johan,

Johan Hovold æ 2015/6/25 äå 04:06 åé:
>   - As Greg already mentioned, you need to implement gpio support using
>     gpiolib, not a custom sysfs interface
>
> I don't have time to look closer at the architectural bits until next
> week I'm afraid, but perhaps you could start with the above.

Thanks for your advices, I'll try to improve it again.
But I had something need to clarify.

1. The sysfs interface of the driver provide "limited output pin"
   control. only support output 0/1, not support input mode.
   Should I implement it as gpiolib?

2. If it still recommends to implement with gpiolib, Could I implement
   it and preserve the sysfs interface for legacy?

--
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/