Re: [PATCH 0/2] ARM: /proc/atags: Export also for DT

From: Russell King - ARM Linux
Date: Thu Jun 25 2015 - 06:04:09 EST


On Fri, May 15, 2015 at 09:50:05PM +0200, Pali Rohár wrote:
> This patch adds support for DT "/atags" and stores ATAG structure to DT.
>
> It depends on "ARM: /proc/cpuinfo: DT: Add support for Revision" patches.
>
> Pali Rohár (2):
> arm: devtree: Save atags if are in DT atags field
> arm: boot: store ATAG structure into DT atag field
>
> arch/arm/boot/compressed/atags_to_fdt.c | 6 +++++-
> arch/arm/kernel/devtree.c | 6 ++++++
> 2 files changed, 11 insertions(+), 1 deletion(-)

What these patches are missing is a description of _why_ this is required
in any of the commit messages. The commit messages seem to be describing
_what_ the change is doing, which is something that can be seen by reading
the patches, but it leaves the question of why this change is necessary
entirely open.

Please update the commit messages on the next patch revision.

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/