Re: [PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect()

[Tom Herbert]

On Thu, Jun 25, 2015 at 6:10 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> net/core/flow_dissector.c: In function â__skb_flow_dissectâ:
> net/core/flow_dissector.c:132: warning: âip_protoâ may be used uninitialized in this function
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> This may be a false positive, but the state machine in
> __skb_flow_dissect() is a bit hard to follow.
> As I believe it is controlled by a packet received from the network, the
> only safe thing to do is to pre-initialize ip_proto.
> ---
>  net/core/flow_dissector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 476e5dda59e19822..2a834c6179b9973e 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -129,7 +129,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
>         struct flow_dissector_key_ports *key_ports;
>         struct flow_dissector_key_tags *key_tags;
>         struct flow_dissector_key_keyid *key_keyid;
> -       u8 ip_proto;
> +       u8 ip_proto = 0;
>
>         if (!data) {
>                 data = skb->data;
> --
> 1.9.1
>

Acked-by: Tom Herbert <tom@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/