Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators
From: Juston Li
Date: Thu Jun 25 2015 - 12:26:08 EST
On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee
<sudipm.mukherjee@xxxxxxxxx> wrote:
> On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote:
>> fixes checkpatch.pl error:
>> ERROR: need consistent spacing around ''
> little bit confused.
> 1) Your subject says consistent space around operators but here it says
> around ''
The specific checkpatch.pl error was different for each error, the quotes
were suppose to contain the specific operator but I left it out so that there
would be one generic error message. The quotes left behind were confusing,
sorry.
> 2) Considering that you are giving consitent space around operators, then
> i think you have missed few operators like '|','&',':' in this
> patch.
>
These were the only instances the checkpatch.pl error came up. This patch
only fixes even spacing around a specific operator. Other operators either
have even or no spacing around them with PATCH 11/19 fixing any operators
with spacing around required. This leaves operators that checkpatch deems
spacing as optional which I left as a separate issue to be addressed of making
optional spacing of operators consistent with each other.
Thanks
Juston
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/