Re: [PATCH v2 15/17] libnvdimm: Set numa_node to NVDIMM devices

[Dan Williams]

On Thu, Jun 25, 2015 at 10:45 AM, Toshi Kani <toshi.kani@xxxxxx> wrote:
> On Thu, 2015-06-25 at 05:37 -0400, Dan Williams wrote:
>> From: Toshi Kani <toshi.kani@xxxxxx>
>>
>> ACPI NFIT table has System Physical Address Range Structure entries that
>> describe a proximity ID of each range when ACPI_NFIT_PROXIMITY_VALID is
>> set in the flags.
>>
>> Change acpi_nfit_register_region() to map a proximity ID to its node ID,
>> and set it to a new numa_node field of nd_region_desc, which is then
>> conveyed to the nd_region device.
>>
>> The device core arranges for btt and namespace devices to inherit their
>> node from their parent region.
>>
>> Signed-off-by: Toshi Kani <toshi.kani@xxxxxx>
>> [djbw: move set_dev_node() from region 'probe' to 'create']
>
> Sorry, I failed to mention other issue, which led me call set_dev_node()
> in probe.  nd_async_device_register() calls device_add(), which does:
>
>         /* use parent numa_node */
>         if (parent)
>                 set_dev_node(dev, dev_to_node(parent));
>
> and overwrites numa_node to -1.  Since region's parent is ndbusN, we
> cannot set numa_node to the parent.  So, I had to set it in probe.

ah, ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/