Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

From: majun (F)
Date: Fri Jun 26 2015 - 08:05:10 EST




在 2015/6/26 18:40, Marc Zyngier 写道:
>
> My opinion is that we need to be able to lookup the domain from the core
> code without any of these hacks, and this is what I'm working on at the
> moment. There is no way external code will be allowed to mess with the
> internals of the ITS.
>
> For the time being, just expose the domain with a helper (you can match
> it with the of_node).
Do you mean add a fucntion in ITS likes below:

struct irq_domain *get_its_domain(struct device_node *node)
{
struct its_node *its = NULL;

list_for_each_entry(its, &its_nodes, entry) {
if(its->msi_chip.of_node == node)
break;
}

return (its)?its->domain:NULL;
}

How about add a '.match ' member in its_domain_ops
just like:
.match = get_its_domain;

So, I can use the fucntion 'irq_find_host' in mbigne driver

>In the long run, you should be able to look it up
> directly from the domain list.
>
I think the domain list you said is 'irq_domain_list'
which defined in Irqdomain.c
static LIST_HEAD(irq_domain_list);

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/