Re: [PATCH 3/4] staging: wilc1000: remove whitespaces before quoted newlines

From: Joe Perches
Date: Fri Jun 26 2015 - 10:49:49 EST


On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
> Fix all checkpatch.pl warnings:
> WARNING: unnecessary whitespace before a quoted newline

Unassociated but:

> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
[]
> @@ -740,7 +740,7 @@ s32 Handle_set_IPAddress(void *drvHandler, u8 *pu8IPAddr, u8 idx)
> if (pu8IPAddr[0] < 192)
> pu8IPAddr[0] = 0;
>
> - PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %d.%d.%d.%d \n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8IPAddr[2], pu8IPAddr[3]);
> + PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %d.%d.%d.%d\n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8IPAddr[2], pu8IPAddr[3]);

These printks with ip addresses could use vsprintf extension %pI4

PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %pI4\n",
idx, pu8IPAddr);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/