Re: [bp:tip-mm 11/13] drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc'

[Max Filippov]

On Fri, Jun 26, 2015 at 12:29 PM, Borislav Petkov <bp@xxxxxxx> wrote:
> On Fri, Jun 26, 2015 at 04:28:51PM +0800, kbuild test robot wrote:
>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp tip-mm
>> head:   7b0982330a1b4d4bdb99bb8382e2363165231a90
>> commit: fd50bea9cedd8fdbd091dfccb4b526be0ef9839f [11/13] drivers/video/fbdev/atyfb: Replace MTRR UC hole with strong UC
>> config: xtensa-allyesconfig (attached as .config)
...
>> All error/warnings (new ones prefixed by >>):
>>
>>    drivers/video/fbdev/aty/atyfb_base.c: In function 'atyfb_setup_generic':
>> >> drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc' [-Werror=implicit-function-declaration]
>>      par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>>      ^
>> >> drivers/video/fbdev/aty/atyfb_base.c:3461:19: warning: assignment makes pointer from integer without a cast
>>      par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>>                       ^
...
> Looks to me, xtensa needs something like that:
>
> ---
> From d8ac67e37a1a99e305c5ec57cff084f9f3513e61 Mon Sep 17 00:00:00 2001
> From: Borislav Petkov <bp@xxxxxxx>
> Date: Fri, 26 Jun 2015 10:54:40 +0200
> Subject: [PATCH] xtensa/asm: Add ioremap_uc
>
> ... and default to the uncacheable version.
>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> Cc: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> Cc: Chris Zankel <chris@xxxxxxxxxx>
> Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Toshi Kani <toshi.kani@xxxxxx>
> Cc: linux-xtensa@xxxxxxxxxxxxxxxx
> ---
>  arch/xtensa/include/asm/io.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/xtensa/include/asm/io.h b/arch/xtensa/include/asm/io.h
> index c39bb6e61911..34f707ea619b 100644
> --- a/arch/xtensa/include/asm/io.h
> +++ b/arch/xtensa/include/asm/io.h
> @@ -60,6 +60,7 @@ static inline void __iomem *ioremap_cache(unsigned long offset,
>
>  #define ioremap_wc ioremap_nocache
>  #define ioremap_wt ioremap_nocache
> +#define ioremap_uc ioremap_nocache
>
>  static inline void __iomem *ioremap(unsigned long offset, unsigned long size)
>  {
> --

Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx>

-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/