Re: imx: apf27: the board no longer boot with latest git kernel

[Philippe Reynes]

Hi Fabio,

On 27/06/15 19:05, Fabio Estevam wrote:
> Hi Philippe,
>
> On Sat, Jun 27, 2015 at 10:21 AM, Philippe Reynes<tremyfr@xxxxxxxxx>  wrote:
> > Hi all,
> >
> > I've tested the lastest linus git kernel, and this kernel
> > no longer boot on my armadeus apf27. The last line of the
> > log are (after, the kernel is stalled) :
> >
> > [    0.000000] CPU identified as i.MX27, silicon rev 2.1
> > [    0.000000] Switching to timer-based delay loop, resolution 60ns
> > [    0.000024] sched_clock: 32 bits at 16MHz, resolution 60ns, wraps every
> > 129171917793ns
> > [    0.008172] clocksource mxc_timer1: mask: 0xffffffff max_cycles:
> > 0xffffffff, max_idle_ns: 114963006693 ns
> > [    0.020252] Console: colour dummy device 80x30
> > [    0.024894] Calibrating delay loop (skipped), value calculated using
> > timer frequency..
> >
> > I've done a bisect and the commit that raise this issue is :
> > db2ae4b4f6b79bd11d6461d41bd0966b0006f20b
> > ARM: imx: provide gpt device specific irq functions
> >
> > Do you also reproduce this issue please ? or may be I've missed
> > to enable an new option ?
>
> I don't have access to a mx27 board at the moment, but I am wondering
> if the change below would fix the problem:

I've got one, and I can do the test.
 
> --- a/drivers/clocksource/timer-imx-gpt.c
> +++ b/drivers/clocksource/timer-imx-gpt.c
> @@ -528,6 +528,7 @@ static void __init imx6dl_timer_init_dt(struct device_node *
>   }
>
>   CLOCKSOURCE_OF_DECLARE(imx1_timer, "fsl,imx1-gpt", imx1_timer_init_dt);
> +CLOCKSOURCE_OF_DECLARE(imx27_timer, "fsl,imx27-gpt", imx1_timer_init_dt);
>   CLOCKSOURCE_OF_DECLARE(imx21_timer, "fsl,imx21-gpt", imx21_timer_init_dt);
>   CLOCKSOURCE_OF_DECLARE(imx31_timer, "fsl,imx31-gpt", imx31_timer_init_dt);
>   CLOCKSOURCE_OF_DECLARE(imx25_timer, "fsl,imx25-gpt", imx31_timer_init_dt);

I've looked the code in drivers/clocksource/timer-imx-gpt.c, in the definition
of imx_gpt_type, there is :
	GPT_TYPE_IMX21,		/* i.MX21/27 */

So I've done a little change in your patch, I've used imx21_timer_init_dt for
imx27 :

--- a/drivers/clocksource/timer-imx-gpt.c
+++ b/drivers/clocksource/timer-imx-gpt.c
@@ -529,6 +529,7 @@ static void __init imx6dl_timer_init_dt(struct device_node *np)
 
 CLOCKSOURCE_OF_DECLARE(imx1_timer, "fsl,imx1-gpt", imx1_timer_init_dt);
 CLOCKSOURCE_OF_DECLARE(imx21_timer, "fsl,imx21-gpt", imx21_timer_init_dt);
+CLOCKSOURCE_OF_DECLARE(imx27_timer, "fsl,imx27-gpt", imx21_timer_init_dt);
 CLOCKSOURCE_OF_DECLARE(imx31_timer, "fsl,imx31-gpt", imx31_timer_init_dt);
 CLOCKSOURCE_OF_DECLARE(imx25_timer, "fsl,imx25-gpt", imx31_timer_init_dt);
 CLOCKSOURCE_OF_DECLARE(imx50_timer, "fsl,imx50-gpt", imx31_timer_init_dt);

I've tested it, and it works fine, now my apf27 (imx27) boot without any issue.
So good catch, thanks a lot for this patch.

I may send a patch on lkml if you want.

> Regards,
>
> Fabio Estevam

Regards,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/