Re: [PATCH] block: fix bogus EFAULT error from SG_IO ioctl

From: Jens Axboe
Date: Sat Jun 27 2015 - 13:44:07 EST


On 06/26/2015 03:44 AM, Paolo Bonzini wrote:
Whenever blk_fill_sghdr_rq fails, its errno code is ignored and changed to
EFAULT. This can cause very confusing errors:

$ sg_persist -k /dev/sda
persistent reservation in: pass through os error: Bad address

The fix is trivial, just propagate the return value from
blk_fill_sghdr_rq.

Added, thanks.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/