Re: [tip:irq/urgent] avr32/at32ap: Fix race in installing chained IRQ handler

From: Hans-Christian Egtvedt
Date: Sun Jun 28 2015 - 14:16:37 EST


Around Fri 26 Jun 2015 12:47:18 -0700 or thereabout, tip-bot for Thomas Gleixner wrote:
> avr32/at32ap: Fix race in installing chained IRQ handler
>

<snipp>


> Reported-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Julia Lawall <Julia.Lawall@xxxxxxx>
> Cc: Haavard Skinnemoen <hskinnemoen@xxxxxxxxx>
> Cc: Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>
> ---
> arch/avr32/mach-at32ap/extint.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/avr32/mach-at32ap/extint.c b/arch/avr32/mach-at32ap/extint.c
> index cfb298d..2d48b6a 100644
> --- a/arch/avr32/mach-at32ap/extint.c
> +++ b/arch/avr32/mach-at32ap/extint.c
> @@ -231,8 +231,7 @@ static int __init eic_probe(struct platform_device *pdev)
> irq_set_chip_data(eic->first_irq + i, eic);
> }
>
> - irq_set_chained_handler(int_irq, demux_eic_irq);
> - irq_set_handler_data(int_irq, eic);
> + irq_set_chained_handler_and_data(int_irq, demux_eic_irq, eic);
>
> if (pdev->id == 0) {
> nmi_eic = eic;

Good fix, wil you pass it through your git tree, or would you prefer I add it
to the AVR32 tree? I have nothing in the pipe, hence feel free to add it to a
series if you are preparing fixes.

Acked-by: Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>

--
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/