Re: [PATCH]: MUX n_gsm debug print improvements

From: Greg KH
Date: Mon Jun 29 2015 - 12:02:50 EST


On Mon, Jun 29, 2015 at 05:54:58PM +0200, Gwenn Bourrée wrote:
>
> Dear kernel tty maintainers,
>
> Please review the following patch:
>
> From 0ac5da0a4653f43ce4b0761a2be8073185c549bb Mon Sep 17 00:00:00 2001
> From: Gwenn Bourree <gwenn.bourree@xxxxxxxxx>
> Date: Mon, 29 Jun 2015 16:09:06 +0200
> Subject: [PATCH] Add Debug define
>
> Improve the debug print out and make be clearest
>
> Signed-off-by: Gwenn Bourree <gwenn.bourree@xxxxxxxxx>
> Signed-off-by: Mustapha Ben Zoubeir <mustaphax.ben.zoubeir@xxxxxxxxx>
> Signed-off-by: Nicolas LOUIS <nicolasx.louis@xxxxxxxxx>
> Reviewed-by: Ravindran, Arun <arun.ravindran@xxxxxxxxx

Any reason you didn't cc the linux-serial mailing list? And linux-api
only cares about external api changes, which I don't think you did here.

Also, what's with the odd format, I would have to hand-edit this in
order to apply it properly. Please fix it up and send it without the
"Dear..." lines, that's not needed at all, nor is the "From" lines.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/