Re: [PATCH tip/core/rcu 24/24] rcu: Conditionally compile RCU's eqs warnings

[Geert Uytterhoeven]

Hi Paul,

On Mon, Jun 29, 2015 at 10:55 PM, Paul E. McKenney
<paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Jun 29, 2015 at 11:39:13AM +0200, Geert Uytterhoeven wrote:
>> On Wed, May 13, 2015 at 12:30 AM, Paul E. McKenney
>> <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
>> > --- a/lib/Kconfig.debug
>> > +++ b/lib/Kconfig.debug
>> > @@ -1373,6 +1373,17 @@ config RCU_TRACE
>> >           Say Y here if you want to enable RCU tracing
>> >           Say N if you are unsure.
>> >
>> > +config RCU_EQS_DEBUG
>> > +       bool "Use this when adding any sort of NO_HZ support to your arch"
>>
>> This sounds a bit fuzzy. Can you please provide a better one-line description?
>> Thanks!
>
> So the point of this Kconfig option is to provide WARN_ON()s that catch
> bug such as telling RCU that a given CPU entered idle, but failing to
> tell RCU when that CPU later leaves idle.  So how about this?
>
> +       bool "Provide debugging asserts for adding NO_HZ support to an arch"

Much better, thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/