RE: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

[Subbaraya Sundeep Bhatta]

Hi Felipe,

> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@xxxxxx]
> Sent: Tuesday, June 30, 2015 3:17 AM
> To: Subbaraya Sundeep Bhatta
> Cc: balbi@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Subbaraya Sundeep
> Bhatta
> Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command
> sent to DEPCMD register fails
> 
> Hi,
> 
> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta
> wrote:
> > We need to return error to caller if command is not sent to controller
> > succesfully.
> >
> > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxx>
> > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > ---
> > v2 changes:
> > 	Added Fixes and Cc in commit message.
> 
> I noticed that this breaks at least my AM437x silicon with DWC3 2.40a
> when used with g_zero and testusb. As of now, it could be that silicon is
> mis-behaving because I got a Transfer Complete before the failing Set
> Endpoint Transfer Resource command.
> 
> In any case, can you run on your setup with g_zero and test.sh/testusb
> [1]/[2] just to verify that it really works for you ?

Ok I will do that.

Thanks,
Sundeep.B.S.

> 
> Meanwhile, I'll continue testing on my end.
> 
> cheers
> 
> [1] https://gitorious.org/usb/usb-
> tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:testusb.c
> [2] https://gitorious.org/usb/usb-
> tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:test.sh
> 
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/