Re: [PATCH] ARM: psci: keystone: remove keystone_smp_ops code if psci is supported

From: Russell King - ARM Linux
Date: Wed Jul 01 2015 - 10:12:43 EST


On Wed, Jul 01, 2015 at 08:13:03AM -0400, Vitaly Andrianov wrote:
> If we enable psci support we don't need keystone_smp_ops anymore.
>
> Signed-off-by: Vitaly Andrianov <vitalya@xxxxxx>

However, this is not necessary. If you look at arch/arm/kernel/setup.c,
it contains this:

psci_init();
#ifdef CONFIG_SMP
if (is_smp()) {
if (!mdesc->smp_init || !mdesc->smp_init()) {
if (psci_smp_available())
smp_set_ops(&psci_smp_ops);
else if (mdesc->smp)
smp_set_ops(mdesc->smp);
}
smp_init_cpus();
smp_build_mpidr_hash();
}
#endif

So, the platforms' SMP ops won't be used even if they're provided
when PSCI is available.

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/