Re: [PATCH v1 09/10] device: property: add fwnode_driver_match_device()

[Rafael J. Wysocki]

On Tuesday, June 30, 2015 04:55:07 PM Tomeu Vizoso wrote:
> So buses can match drivers to devices without having to care about what
> firmware is used to describe the device.
> 
> The introduction of this function will also allow us to introduce
> matching behavior common to the different type of firmwares.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>

Looks OK to me.


> ---
> 
>  drivers/base/property.c  | 18 ++++++++++++++++++
>  include/linux/property.h |  4 ++++
>  2 files changed, 22 insertions(+)
> 
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 9c8be31..8528eb9 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -15,6 +15,7 @@
>  #include <linux/kernel.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
> +#include <linux/of_device.h>
>  #include <linux/property.h>
>  
>  /**
> @@ -594,3 +595,20 @@ bool fwnode_is_compatible(struct fwnode_handle *fwnode, const char *compatible)
>  	return false;
>  }
>  EXPORT_SYMBOL_GPL(fwnode_is_compatible);
> +
> +/**
> + * fwnode_driver_match_device - Tell if a driver matches a device.
> + * @drv: the device_driver structure to test
> + * @dev: the device structure to match against
> + */
> +bool fwnode_driver_match_device(struct device *dev,
> +				const struct device_driver *drv)
> +{
> +	if (is_of_node(dev->fwnode))
> +		return of_driver_match_device(dev, drv);
> +	else if (is_acpi_node(dev->fwnode))
> +		return acpi_driver_match_device(dev, drv);
> +
> +	return false;
> +}
> +EXPORT_SYMBOL_GPL(fwnode_driver_match_device);
> diff --git a/include/linux/property.h b/include/linux/property.h
> index bf10074..4e453c4 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -17,6 +17,7 @@
>  #include <linux/types.h>
>  
>  struct device;
> +struct device_driver;
>  
>  enum dev_prop_type {
>  	DEV_PROP_U8,
> @@ -82,6 +83,9 @@ void fwnode_handle_put(struct fwnode_handle *fwnode);
>  
>  bool fwnode_is_compatible(struct fwnode_handle *fwnode, const char *compatible);
>  
> +bool fwnode_driver_match_device(struct device *dev,
> +				const struct device_driver *drv);
> +
>  unsigned int device_get_child_node_count(struct device *dev);
>  
>  static inline bool device_property_read_bool(struct device *dev,
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/